Telnets without super-admin privileges can still use telnet

[MEGAF4IL]

So, Telnets that lose their SA perms, are still able to use telnet.

I tested this with Lead_Falcon in two ways. (Don't worry, I asked for his permission before testing.)

1. Removed his SA and asked him to add himself back, it worked.
2. Did the same above but asked him to reconnect on telnet after removing SA. Still worked.

Now here's something that concerns me most.

JamelB had resigned, but still has permission to access Telnet.
This is the only Ex-Admin I know of that no longer has admin, but still has access to telnets.

This also of course, only affects Telnets. (And possibly seniors).

[JeromSar]

Removed the humongous title. ;)

[JeromSar]

If the bug report is legitimate, it seems like this is a two-part problem:

• TelnetPreLoginEvent verifies admins by checking if the appropriate entry exists and fails to verify if the entry is enabled
• Admins aren't kicked from telnet when they are removed.
  This could be resolved by adding a session API to BukkitTelnet.

[Robolord]

This used to happen on RoboFreedom >. < so i ended up removing them from superadmiin.yml entirely

[ExactObject]

I just changed the telnet & senior flags to false for any inactive admin.

[JeromSar]

@markbyrn Steven just fixed the first issue, deactivated telnet-admins no longer have access to telnet.

[StevenLawson]

Do we even need to address the second issue? I think it would be a lot of extra stuff for a situation that just doesn't happen that often, if ever. If necessary, you can use /saconfig to remove an admin and then do a /reload right away and they'll get kicked off Telnet.

[JeromSar]

@StevenLawson Fair point, feel free to close. :)