Another stab at tempfile #56
Conversation
The implementation is based on the following PRs: - Tinche/aiofiles#32 - Tinche/aiofiles#56 The code uses aiofiles internals.
The implementation is based on the following PRs: - Tinche/aiofiles#32 - Tinche/aiofiles#56 The code uses aiofiles internals.
|
Can you please fix the conflict if you have time? We need a tempfile rolled in. It's been years since adding it was first talked about. Seems like this one should have been merged. |
|
@Tinche - do you have interest to add this? Can update the pull request and add testing if helpful |
updated |
|
Any update on whether this fixes #20? |
|
you can try https://github.com/alemigo/asynctempfile in the meantime |
|
I think this PR can be squashed to be ready for merge. |
|
Can a maintainer please confirm, that this will be merged so I can start using @alemigo's branch now and then switch back to a aiofiles release later? |
|
Will this be merged soon? |
|
It will be really helpful if this is released |
|
https://github.com/alemigo/asynctempfile is the same code for tempfile support as this PR |
|
Alright, since there's interest I can merge this in. But it needs tests first. |
Ok I will add |
Excellent, thanks. Also some documentation on how to use it would be cool. |
Tinche
left a comment
Tinche
left a comment
There was a problem hiding this comment.
Looks good, left a couple of comments. Also the PR won't merge cleanly for me, might have to rebase on master. Thanks!
Rebase
Thx - made the changes |
|
Looks good, thanks a lot! |
7 participants
Async tempfile implementation following the existing structure, with a bit extra for SpooledTemporaryFile where delegation is not required unless the in-memory stream is rolled to disk.