Added Manifest file #31
Conversation
|
Thanks! Do you need me to do a release to PyPI? |
|
The only file that should be mentioned there is |
|
@Tinche a release would be great! Thank You! |
|
@Tinche please ping me here conda-forge/staged-recipes#4192 after the release |
| recursive-include aiofiles *.py | ||
|
|
||
| include README.rst | ||
| include MANIFEST.in |
There was a problem hiding this comment.
Sorry for a comment after merging but MANIFEST.in is not needed in the file.
Maybe it doesn't make a harm but no other project has the line IMHO.
I'm pretty sure aio-libs: aiohttp, yarl, multidict and others works pretty well.
There was a problem hiding this comment.
MANIFEST.in, MANIFEST and setup.py don’t need to be in MANIFEST.in, indeed.
| @@ -0,0 +1,6 @@ | |||
| recursive-include aiofiles *.py | |||
There was a problem hiding this comment.
The line should be removed: setuptools/distutils has a rule to include all .py files from mentioned packages.
|
Uh, it works like it is now, so I'm not in a rush to fix it. If someone wants to submit a cleanup PR, I'll be happy to merge it in :) |
5 participants
see conda-forge/staged-recipes#4192