Skip to content

Conversation

@93578237
Copy link
Contributor

@93578237 93578237 commented Nov 18, 2021

Closes #112
I also used black (maybe I should not?) because there is no rule about the code style

@Tinche
Copy link
Owner

Tinche commented Nov 26, 2021

Looks good. Could you add a line to the changelog in the readme?

@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2021

Codecov Report

Merging #116 (5ae63a4) into master (8895eb4) will increase coverage by 0.03%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #116      +/-   ##
==========================================
+ Coverage   89.56%   89.59%   +0.03%     
==========================================
  Files          10       10              
  Lines         297      298       +1     
==========================================
+ Hits          266      267       +1     
  Misses         31       31              
Impacted Files Coverage Δ
src/aiofiles/base.py 70.96% <0.00%> (ø)
src/aiofiles/tempfile/__init__.py 95.08% <100.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8895eb4...5ae63a4. Read the comment docs.

@93578237
Copy link
Contributor Author

Done

@Tinche
Copy link
Owner

Tinche commented Nov 26, 2021

Thanks a lot!

@Tinche Tinche merged commit 713984e into Tinche:master Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TemporaryDirectory is missing keyword arguments from upstream

3 participants