Draft
Conversation
Introduce themed_grid and configure_grid utilities (and spacing resolution helpers) to centralize spacing, padding and grid configuration using theme tokens. Replace many direct .grid/.grid_rowconfigure calls across the main window, tabs and panels with themed_grid/configure_grid to enforce consistent layout and spacing. Extend theme presets with layout and padding tokens (layout_window/panel/section/control gaps, canvas/sidebar sizes, panel/card paddings) and adjust notebook tab styling/padding. Make camera/display sizing and resize handling more robust: add _get_canvas_widget_size helper, allow update_canvas_size to accept optional width/height, reduce refresh debounce and tighten size-change thresholds, bind resize handler to the canvas and track binding IDs, and add extra defensive checks to avoid tiny/invalid sizes. Minor controller change: call update_idletasks during main resize to ensure measurements are stable.
Replace direct grid calls with themed_grid and configure_grid across multiple UI modules to centralize layout behavior and support theme spacing tokens. Add get_theme_spacing usage and a helper _resolve_pad_value to allow padding to be specified as theme tokens or raw numbers, and update LabelInput.pad_input to resolve tokens. Fix PhotoImage master usage and adjust various grid/padding calls to use theme spacing identifiers. Update and extend tests: adapt LabelInput tests and add test_main_ui_layout to assert weighted layout configuration.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #1202 +/- ##
===========================================
+ Coverage 55.51% 55.61% +0.09%
===========================================
Files 189 189
Lines 24977 25049 +72
===========================================
+ Hits 13866 13931 +65
- Misses 11111 11118 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.