Skip to content

Support Piezo as stage#1198

Merged
AdvancedImagingUTSW merged 1 commit intodevelopfrom
piezo-support
Mar 6, 2026
Merged

Support Piezo as stage#1198
AdvancedImagingUTSW merged 1 commit intodevelopfrom
piezo-support

Conversation

@Johnhaug223
Copy link
Collaborator

fixes default_axes_sequence to include axes with type "p" (piezo) as a motor axis

@codecov
Copy link

codecov bot commented Mar 2, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 54.70%. Comparing base (8a69f89) to head (88c3ce1).
⚠️ Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
...ate/model/devices/APIs/asi/asi_tiger_controller.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1198      +/-   ##
===========================================
- Coverage    54.71%   54.70%   -0.01%     
===========================================
  Files          189      189              
  Lines        24778    24779       +1     
===========================================
- Hits         13557    13556       -1     
- Misses       11221    11223       +2     
Flag Coverage Δ
unittests 54.70% <66.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@AdvancedImagingUTSW AdvancedImagingUTSW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure that this works on other ASI systems and let me know. One thing that pops up is that set_speed_as_percent_max now dereferences self.default_axes_sequence before validating it, which could raise TypeError instead of ASIException.

@AdvancedImagingUTSW AdvancedImagingUTSW self-requested a review March 6, 2026 19:01
@AdvancedImagingUTSW AdvancedImagingUTSW merged commit 0d0510d into develop Mar 6, 2026
1 check passed
@AdvancedImagingUTSW AdvancedImagingUTSW deleted the piezo-support branch March 6, 2026 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants