Skip to content

Conversation

@cclauss
Copy link
Member

@cclauss cclauss commented Oct 26, 2022

Fixes #7682

@dhruvmanila @ChrisO345 Temporarily disable quantum_random.py which is causing sporadic pytest failures.

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@cclauss cclauss requested a review from dhruvmanila October 26, 2022 15:53
@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 26, 2022
@cclauss cclauss requested a review from ChrisO345 October 26, 2022 15:54
@dhruvmanila
Copy link
Member

Um, it's better to ignore the file in pytest.ini or command-line call instead of this.

@cclauss
Copy link
Member Author

cclauss commented Oct 26, 2022

I disagree. This is a temporary change. Doing it this way, we can see just by looking at the file that it is disabled. That information is not hidden away so ini file that no one ever looks at.

@cclauss cclauss merged commit 74325d0 into master Oct 26, 2022
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 26, 2022
@cclauss cclauss deleted the quantum_random.py.DISABLED.txt branch October 26, 2022 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement This PR modified some existing files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants