Skip to content

Fix some SIM114 per file ignores #11395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 10, 2024
Merged

Fix some SIM114 per file ignores #11395

merged 5 commits into from
May 10, 2024

Conversation

@MaximSmolskiy
Copy link
Member

Describe your change:

Fix some SIM114 per file ignores

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels May 6, 2024
@algorithms-keeper algorithms-keeper bot added tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels May 6, 2024
cclauss
cclauss reviewed May 10, 2024
View reviewed changes
data_structures/binary_tree/treap.py
if root is None: # None tree is split into 2 Nones
return None, None
elif root.value is None:
if root is None or root.value is None: # None tree is split into 2 Nones
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This improves readability.

The other instances do not improve readability.

@MaximSmolskiy MaximSmolskiy requested a review from cclauss May 10, 2024 09:59
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label May 10, 2024
@cclauss cclauss merged commit c599f6c into TheAlgorithms:master May 10, 2024
@MaximSmolskiy MaximSmolskiy deleted the fix-some-SIM114-per-file-ignores branch May 10, 2024 21:59
cclauss pushed a commit to cclauss/Python that referenced this pull request Sep 30, 2024
@MaximSmolskiy @pre-commit-ci @cclauss
Fix some SIM114 per file ignores (TheAlgorithms#11395)
1ec9a68 
* updating DIRECTORY.md

* Fix some SIM114 per file ignores

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix review issue

---------

Co-authored-by: MaximSmolskiy <MaximSmolskiy@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
cclauss pushed a commit to cclauss/Python that referenced this pull request Sep 30, 2024
@MaximSmolskiy @pre-commit-ci @cclauss
Fix some SIM114 per file ignores (TheAlgorithms#11395)
20c1c65 
* updating DIRECTORY.md

* Fix some SIM114 per file ignores

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix review issue

---------

Co-authored-by: MaximSmolskiy <MaximSmolskiy@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclauss cclauss cclauss approved these changes

+1 more reviewer

@imSanko imSanko imSanko approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement This PR modified some existing files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MaximSmolskiy @cclauss @imSanko