Skip to content

Add ValidateUrl in String #856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 2, 2021
Merged

Add ValidateUrl in String #856

merged 3 commits into from
Dec 2, 2021

Conversation

Yatin-kathuria
Copy link
Contributor

Welcome to JavaScript community

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@lgtm-com
Copy link

lgtm-com bot commented Nov 28, 2021

This pull request introduces 1 alert when merging b021d45 into 027c0d6 - view on LGTM.com

new alerts:

  • 1 for Inefficient regular expression

raklaptudirm
raklaptudirm requested changes Nov 28, 2021
View reviewed changes
@raklaptudirm raklaptudirm added algorithm Adds or improves an algorithm changes required This pull request needs changes feature Adds a new feature Reviewed labels Nov 28, 2021
@raklaptudirm raklaptudirm removed the changes required This pull request needs changes label Nov 29, 2021
raklaptudirm
raklaptudirm requested changes Nov 29, 2021
View reviewed changes
@raklaptudirm raklaptudirm added the changes required This pull request needs changes label Nov 29, 2021
@raklaptudirm raklaptudirm removed the changes required This pull request needs changes label Dec 2, 2021
@raklaptudirm raklaptudirm merged commit 6fb649e into TheAlgorithms:master Dec 2, 2021
@Yatin-kathuria Yatin-kathuria deleted the validateUrl branch December 2, 2021 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raklaptudirm raklaptudirm raklaptudirm approved these changes

Assignees
No one assigned
Labels
algorithm Adds or improves an algorithm feature Adds a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yatin-kathuria @raklaptudirm