Skip to content

Conversation

RenatoLopes771
Copy link
Contributor

Welcome to JavaScript community

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

I made the following changes:

  • Commit 1:
    Add a extra blank line to end of readme.md file to follow convention

  • Commit 2:
    Most of the tests on this repo are in a /test folder inside their respective folder. Even folders with only one algorithm and one test. Thus I put all the other tests not following this convention to follow them.

Altough one of the rules is to change only one algorithm file per PR, there was no change to the actual algorithm, and it's more of a structural change. Thus I feel like the commit should be judged as a whole instead of separate commits/PR.

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@raklaptudirm raklaptudirm added feature Adds a new feature Reviewed labels Oct 28, 2021
@raklaptudirm raklaptudirm merged commit 1cef191 into TheAlgorithms:master Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adds a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants