Skip to content

Conversation

@vil02
Copy link
Member

@vil02 vil02 commented May 15, 2024

Open in Gitpod know more

Describe your change:

This PR adds missing tests and handles wrong inputs in HexToDecimal.

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@vil02 vil02 marked this pull request as ready for review May 15, 2024 20:49
@raklaptudirm raklaptudirm merged commit 3623e42 into TheAlgorithms:master May 25, 2024
@vil02 vil02 deleted the test_HexToDecimal branch May 25, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants