Skip to content

Conversation

aryan0078
Copy link

@aryan0078 aryan0078 commented Oct 20, 2023

Open in Gitpod know more

Describe your change:

I have Added TimeCache Which can cache items in Map for provided time period and can destroy itself after that particular time it's efficient way of storing data if you have large amount of values to be stored in cache

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@aryan0078 aryan0078 changed the title + Added Time Cache Added Time Cache Oct 20, 2023
@aryan0078
Copy link
Author

@raklaptudirm
@appgurueu
Please review

Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, but I'm afraid a wrapper around a map - while perhaps useful in practice - is not really a good fit for this repo; its implementation here is questionable (keys are only removed when you access them - this may lead to memory leaks and largely defeats the purpose of letting keys expire at all), and it is not very reusable - in most algorithms, wall time is not and should not be a factor.

@appgurueu appgurueu closed this Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants