Skip to content

Create knapsack.js #1521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Create knapsack.js #1521

wants to merge 1 commit into from

Conversation

100mya
Copy link

@100mya 100mya commented Oct 13, 2023

created knapsack.js - solving knapsack problem using backtracking algorithm

appgurueu
appgurueu requested changes Oct 15, 2023
View reviewed changes
Copy link
Collaborator

@appgurueu appgurueu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The class is unnecessary. Refactor this to be a single function which gets values, weights, and capacity as parameters, and returns the max. knapsack value.
  • Needs tests and a JSDoc comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appgurueu appgurueu appgurueu requested changes

@raklaptudirm raklaptudirm Awaiting requested review from raklaptudirm raklaptudirm is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@100mya @appgurueu