feat:BidirectionalSearch Algorithm #1483
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AmbrishRamachandiran <ambrish.r@infosys.com>
AmbrishRamachandiran
requested review from
raklaptudirm and
appgurueu
as code owners
appgurueu
reviewed
Oct 9, 2023
Graphs/BidirectionalSearch.js
Outdated
| /* | ||
| Bidirectional search is a graph search algorithm that finds a shortest path from an initial vertex to a goal vertex in a directed graph. | ||
| It runs two simultaneous searches: one forward from the initial state, and one backward from the goal, stopping when the two meet. | ||
| The reason for this approach is that in many cases it is faster: for instance, in a simplified model of search problem complexity in which both searches expand a tree with branching factor b, and the distance from start to goal is d, each of the two searches has complexity O(bd/2) (in Big O notation), |
There was a problem hiding this comment.
The big-O here doesn't make sense. You probably mean O(b^(d/2)) and O(b^d).
There was a problem hiding this comment.
@appgurueu fixed it please check
Signed-off-by: AmbrishRamachandiran <ambrish.r@infosys.com>
Signed-off-by: AmbrishRamachandiran <ambrish.r@infosys.com>
appgurueu
requested changes
Oct 9, 2023
There was a problem hiding this comment.
- Don't create yet another adjacency list representation. Either use / adapt an existing one, or just expect your input to be in the proper format (e.g. array of arrays).
- In accordance with 1,
bidirectionalSearchshould just be a function or a method on an adjacency-list basedGraphclass (which we already have, look into the existing graph data structures). - You're using
shiftto pop the first element from the queues, which has linear time complexity. Please use our linked queues or similar to achieve constant time complexity.
Otherwise the code looks fine!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
Checklist:
Example:
UserProfile.jsis allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.jsare notFixes: #{$ISSUE_NO}.