-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
Added Rectangle.js and Rectangle.test.js to "Geometry" and it's "test" Directories #1413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@appgurueu @raklaptudirm please approve this PR and merge this so that it can be eligible for hacktoberfest |
@appgurueu @raklaptudirm please check my PR #1413 and approve for hacktoberfest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, but this is trivial. I don't see any algorithmic value yet.
Can I update the comment? @appgurueu |
This is not about a comment, this is about the contents of this PR (adding a trivial rectangle class with area / perimeter functions) which I don't see adding much value. To quote the contribution guidelines:
(note: we'll try to make it more clear in the future what our expectations are, and that we mostly aren't interested in trivial algorithms; if in doubt, open an issue before working on an implementation) |
Describe your change:
Checklist:
Example:
UserProfile.js
is allowed butuserprofile.js
,Userprofile.js
,user-Profile.js
,userProfile.js
are notFixes: #{$ISSUE_NO}
.