Skip to content

fix:#758 Average Median code cleanup #1388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 2, 2023
Merged

fix:#758 Average Median code cleanup #1388

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4e38ab5
fix: #758 optimised armstrongNumber code
developerr-ayush Sep 30, 2023
f8f0e2a
Merge branch 'master' of https://github.com/developerr-ayush/JavaScript
developerr-ayush Oct 1, 2023
184ae84
fix:#758 Average Median code optimised
developerr-ayush Oct 1, 2023
b8be2f9
feat: TwoSum function added with test cases
developerr-ayush Oct 1, 2023
882db43
revert code
developerr-ayush Oct 1, 2023
c58f28f
Fix: #758 used ternary operator to make code more optimised
developerr-ayush Oct 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 5 additions & 13 deletions Maths/AverageMedian.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,22 +9,14 @@
*/

const averageMedian = (sourceArrayOfNumbers) => {
let numbers = [...sourceArrayOfNumbers]
let median = 0
const numbers = [...sourceArrayOfNumbers].sort(sortNumbers)
const numLength = numbers.length
numbers = numbers.sort(sortNumbers)

if (numLength % 2 === 0) {
median = (numbers[numLength / 2 - 1] + numbers[numLength / 2]) / 2
} else {
median = numbers[(numLength - 1) / 2]
}

return median
return numLength % 2 === 0
? (numbers[numLength / 2 - 1] + numbers[numLength / 2]) / 2
: numbers[Math.floor(numLength / 2)]
}

const sortNumbers = (num1, num2) => {
return num1 - num2
}
const sortNumbers = (num1, num2) => num1 - num2

export { averageMedian }