Skip to content

fix error in SinglyLinkedList head method #1322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 15, 2023
Merged

fix error in SinglyLinkedList head method #1322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7be303f
fix error in SinglyLinkedList head method
BekzodIsakov May 10, 2023
8e33642
test: update check head test for SinglyLinkedList
BekzodIsakov May 10, 2023
194e302
fix: code style error
BekzodIsakov May 10, 2023
9ba3fba
fix: remove extra semicolons
BekzodIsakov May 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Data-Structures/Linked-List/SinglyLinkedList.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,12 @@ class LinkedList {

// Returns the head
head () {
return this.headNode?.data || null
return this.headNode?.data ?? null
}

// Returns the tail
tail () {
return this.tailNode?.data || null
return this.tailNode?.data ?? null
}

// Return if the list is empty
Expand Down
8 changes: 8 additions & 0 deletions Data-Structures/Linked-List/test/SinglyLinkedList.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,10 @@ describe('SinglyLinkedList', () => {

list.addFirst(30)
expect(list.head()).toBe(30)

// check for a falsy head data
list.addFirst(false)
expect(list.head()).toBe(false)
})

it('Check tail', () => {
Expand All @@ -162,6 +166,10 @@ describe('SinglyLinkedList', () => {

list.addFirst(30)
expect(list.tail()).toBe(20)

// check for a falsy tail data
list.addLast(false)
expect(list.tail()).toBe(false)
})

it('Check size', () => {
Expand Down