Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Maths/PerfectCube.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@
* Author: dephraiim
* License: GPL-3.0 or later
*
* This uses `round` instead of `floor` or `trunc`, to guard against potential `cbrt` accuracy errors
*/

const perfectCube = (num) => Math.round(num ** (1 / 3)) ** 3 === num
const perfectCube = (num) => Number.isFinite(num) && Math.round(Math.cbrt(num)) ** 3 === num

export { perfectCube }
3 changes: 2 additions & 1 deletion Maths/PerfectSquare.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@
* Author: dephraiim
* License: GPL-3.0 or later
*
* This uses `round` instead of `floor` or `trunc`, to guard against potential `sqrt` accuracy errors
*/

const perfectSquare = (num) => Math.sqrt(num) ** 2 === num
const perfectSquare = (num) => Number.isFinite(num) && Math.round(Math.sqrt(num)) ** 2 === num

export { perfectSquare }
2 changes: 2 additions & 0 deletions Maths/test/PerfectCube.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,10 @@ import { perfectCube } from '../PerfectCube'
describe('PerfectCube', () => {
it('should return true for a perfect cube', () => {
expect(perfectCube(125)).toBeTruthy()
expect(perfectCube(-125)).toBeTruthy()
})
it('should return false for a non perfect cube', () => {
expect(perfectCube(100)).toBeFalsy()
expect(perfectCube(Infinity)).toBeFalsy()
})
})
5 changes: 3 additions & 2 deletions Maths/test/PerfectSquare.test.js
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
import { perfectSquare } from '../PerfectSquare'

describe('PerfectSquare', () => {
it('should return true for a perfect cube', () => {
it('should return true for a perfect square', () => {
expect(perfectSquare(16)).toBeTruthy()
})
it('should return false for a non perfect cube', () => {
it('should return false for a non perfect square', () => {
expect(perfectSquare(10)).toBeFalsy()
expect(perfectSquare(Infinity)).toBeFalsy()
})
})