Skip to content

Update directory workflow #1000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 28, 2022
Merged

Update directory workflow #1000

merged 8 commits into from
Apr 28, 2022

Conversation

raklaptudirm
Copy link
Member

No description provided.

@raklaptudirm
chore: update directory workflow
d4fcbf9 
Workflow now only runs on `pull_request` to prevent pushing on the master branch.
@raklaptudirm raklaptudirm requested a review from appgurueu as a code owner April 28, 2022 10:22
appgurueu
appgurueu requested changes Apr 28, 2022
View reviewed changes
Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should run both on push and pull request.

@raklaptudirm
Copy link
Member Author

master is a protected branch, which means that to push to it a pull request is required. That is the reason the directory was not updating.

@raklaptudirm raklaptudirm marked this pull request as draft April 28, 2022 10:27
appgurueu
appgurueu previously approved these changes Apr 28, 2022
View reviewed changes
@raklaptudirm raklaptudirm marked this pull request as ready for review April 28, 2022 11:07
@raklaptudirm raklaptudirm requested a review from appgurueu April 28, 2022 11:07
@raklaptudirm raklaptudirm merged commit e447b55 into master Apr 28, 2022
@raklaptudirm raklaptudirm deleted the directory branch April 28, 2022 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appgurueu appgurueu appgurueu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raklaptudirm @appgurueu