-
Notifications
You must be signed in to change notification settings - Fork 4
chore: bump versions #306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore: bump versions #306
Conversation
WalkthroughThe pull request updates Rust dependencies in the CLI Cargo.toml, upgrading russh and adding rand_core while removing obsolete dependencies. It disables three services (api, bore, device) in the Docker Compose configuration through commenting while adding an explicit build configuration for the postgres service. Changes
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@cli/Cargo.toml`:
- Around line 39-44: The Cargo.toml currently lists an explicit rand_core
dependency that conflicts with rand 0.8's transitive rand_core 0.6; remove the
explicit rand_core = { version = "0.9" } line (or change it to rand_core = "0.6"
if you need to keep it) so the project relies on rand 0.8's compatible
rand_core; verify code uses only rand public API (OsRng, Rng) and run cargo
update/build to confirm no duplicate dependency warnings.
🧹 Nitpick comments (1)
compose.yaml (1)
3-25: Prefer profiles/overrides instead of commenting out services.Commenting out
api,bore, anddeviceremoves them from default workflows and makes re-enabling error-prone. If the intent is “disabled by default,” consider usingprofilesor acompose.override.yamlso the definitions stay valid and easy to toggle. Also confirm this behavior change is intended for a “bump versions” PR.Also applies to: 40-67
| rand = "0.8" | ||
| ed25519-dalek = "2.1.1" | ||
| self_update = { version = "0.42.0", features = ["archive-zip", "compression-zip-deflate"] } | ||
| serde_html_form = "0.2.8" | ||
| cliclack = "0.3.7" | ||
| regex = "1.12.2" | ||
| rand_core = { version = "0.9" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🌐 Web query:
rand 0.8 crate dependencies rand_core version
💡 Result:
rand 0.8.x depends on rand_core 0.6.
- In
rand 0.8.5’s publishedCargo.toml, the dependency isrand_core = ... version = "0.6.0"(Cargo will resolve this as the 0.6.* line, i.e.^0.6.0). [1] - Dependency summary pages also report
rand_corerequired as^0.6.0forrand 0.8.5. [2]
So, if you’re aligning versions manually, use:
rand = "0.8"
rand_core = "0.6"Sources: [1] https://docs.rs/crate/rand/0.8.5/source/Cargo.toml.orig | [2] https://deps.rs/crate/rand/0.8.5
🏁 Script executed:
# Let's also search for any Cargo dependency information in the repo
git ls-files | head -20Repository: Teton-ai/smith
Length of output: 470
🏁 Script executed:
rg "rand_core" --type rustRepository: Teton-ai/smith
Length of output: 40
🏁 Script executed:
rg "RngCore" --type rustRepository: Teton-ai/smith
Length of output: 40
🏁 Script executed:
# Check the full Cargo.toml to understand context
cat cli/Cargo.tomlRepository: Teton-ai/smith
Length of output: 1234
🏁 Script executed:
# Check dependencies of the main workspace crates
cat Cargo.toml | grep -A 50 "\[dependencies\]" | head -60Repository: Teton-ai/smith
Length of output: 40
🏁 Script executed:
# Look for any usage patterns that might justify rand_core 0.9
find . -name "Cargo.toml" -type f | xargs grep -l "rand_core"Repository: Teton-ai/smith
Length of output: 74
🏁 Script executed:
# Check if rand_core is actually needed in the project
rg "use.*rand" --type rust -A 2 | head -50Repository: Teton-ai/smith
Length of output: 363
Remove or align rand_core version with rand 0.8's dependency.
The explicit rand_core = { version = "0.9" } is unnecessary—rand 0.8 already depends on rand_core 0.6. This creates dependency duplication. Since the codebase uses only rand's public API (OsRng, Rng), remove the explicit rand_core dependency or pin it to "0.6" to match rand's requirement.
🤖 Prompt for AI Agents
In `@cli/Cargo.toml` around lines 39 - 44, The Cargo.toml currently lists an
explicit rand_core dependency that conflicts with rand 0.8's transitive
rand_core 0.6; remove the explicit rand_core = { version = "0.9" } line (or
change it to rand_core = "0.6" if you need to keep it) so the project relies on
rand 0.8's compatible rand_core; verify code uses only rand public API (OsRng,
Rng) and run cargo update/build to confirm no duplicate dependency warnings.
closes https://github.com/Teton-ai/smith/security/dependabot/7