Mbedtls symbols

[Shadowtrance]

Plus other symbols

Summary by CodeRabbit

• New Features

  • Added Mbed TLS integration for cryptographic support.

• Chores

  • Expanded exported symbols to include networking/socket, time, and memory utilities.
  • Updated the global symbol resolver to include the new library symbols and prioritize resolution across modules.

[coderabbitai]

📝 Walkthrough

Walkthrough

Adds mbedtls to the module's private requirements and introduces a new header declaring extern const esp_elfsym mbedtls_symbols[]. Adds a new source that defines mbedtls_symbols with many ESP_ELFSYM_EXPORT entries. Integrates mbedtls_symbols into the global symbol resolver in tt_init.cpp and exports additional symbols (explicit_bzero, difftime, lwip_connect, lwip_select, lwip_gethostbyname, ipaddr_addr, select). Re-enables soft-float helpers and adds 32-bit integer-division helpers with corresponding exports in gcc_soft_float.cpp.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Mbedtls symbols' directly reflects the main change: adding mbedtls symbol exports and integration throughout the codebase.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (1)

TactilityC/Source/symbols/gcc_soft_float.cpp (1)

149-154: Minor style nit: missing extern keyword for consistency.

The other function declarations in this extern "C" block use the extern keyword (e.g., lines 15–16, 67–68), while these new ones omit it. Functionally identical, but adding extern would be consistent with the majority of declarations here.

Note: existing declarations at lines 112–113 and 118 also omit extern, so this is a pre-existing inconsistency.

[coderabbitai]

🧹 Nitpick comments (1)

TactilityC/Source/symbols/mbedtls.cpp (1)

72-77: Consider whether additional PK functions are needed.

The PK abstraction section exports init/free/get_type/parse_key/parse_keyfile, but commonly used operations like mbedtls_pk_sign, mbedtls_pk_verify, mbedtls_pk_encrypt, mbedtls_pk_decrypt, and mbedtls_pk_parse_public_key are absent. If ELF consumers will perform signing/verification or public-key parsing through the PK layer (rather than going through the lower-level RSA/ECDSA APIs already exported), they'll hit unresolved symbols at runtime.

Not necessarily a problem if callers are expected to use the RSA/ECDSA exports directly — just flagging for awareness.

[KenVanHoeylandt]

Thank you!!