Tests: Add 219 unit tests for server-side logic#755
Open
hex110 wants to merge 1 commit intoSyncplay:masterfrom
Open
Tests: Add 219 unit tests for server-side logic#755hex110 wants to merge 1 commit intoSyncplay:masterfrom
hex110 wants to merge 1 commit intoSyncplay:masterfrom
Conversation
219 unit tests covering utils, Room, ControlledRoom, RoomManager, Watcher, protocol message handling, PingService, and constants. No existing files modified. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added 219 unit tests across 6 new files to cover the core server-side Syncplay logic.
I also added
conftest.pyto handle shared fixtures (mock Rooms, Watchers, and RoomManagers). No existing source files were modified; everything is contained withintests/.Coverage Breakdown
test_utils.pyparseTime,formatTime,formatSize,isASCII,isURL,meetsMinVersion, filename hashing/sanitization,RoomPasswordProvider,RandomStringGeneratortest_room.pyRoom/ControlledRoomcreation, persistence, play state, position tracking, watcher lifecycle, playlist handling,loadRoomtest_room_manager.pyfindFreeUsername,moveWatcher,removeWatcher,broadcast, andPublicRoomManagerisolationtest_watcher.py__lt__comparison, ready state,isController,updateState, file truncationtest_protocols.pyhandleMessagesdispatch, hello extraction, playstate extraction,sendHello,_SetUserevents,getFeatures,PingServicetest_constants.pygetValueForOS, regex compilation, version string formatHow to test
You will need
pytestand the twisted TLS extras installed.pip install pytest "twisted[tls]" pem certifi pytest tests/ -v