Define desktop filename for Wayland compliance (fixes icon)#627
Merged
Et0h merged 1 commit intoSyncplay:masterfrom Aug 26, 2023
Merged
Define desktop filename for Wayland compliance (fixes icon)#627Et0h merged 1 commit intoSyncplay:masterfrom
Et0h merged 1 commit intoSyncplay:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I've been using Wayland lately and I've noticed that the SyncPlay icon doesn't appear in Wayland:
According to Wayland guidelines,
setWindowIcon()no longer works on Wayland and the new way of doing is is to reference the name of the .desktop file through theQGuiApplication::setDesktopFileName()function:https://community.kde.org/Guidelines_and_HOWTOs/Wayland_Porting_Notes#Application_Icon
I added the required line in ConfigurationGetter.py since that's where the
QApplicationgets created, please tell me if you'd like it elsewhere. This change fixes the icon in Wayland:I used "syncplay" since that's how the .desktop file is called, but the guidelines suggest the desktop file should named in a reverse DNS style, but that's up to you.
Cheers.