Conversation
Et0h
approved these changes
Nov 29, 2020
Contributor
Et0h
left a comment
Et0h
left a comment
There was a problem hiding this comment.
Happy with this change. Tested it, and it works fine for me on Windows (including when I build an installer and run Syncplay from that).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We embed a copy of
python_mpv_jsonipc(https://github.com/iwalton3/python-mpv-jsonipc) in our package to control mpv and IINA. Since this is external code, it would be better to relocate it in thevendorfolder that we already have in out package, for this purpose.