Merged
Conversation
With interpolation and display-sync this ruins the audio. Let the user decide if they want that or not.
Contributor
Author
|
--audio-pitch-correction was introduced in v0.9.0 and since then mpv has always dynamically added scaletempo as needed. |
Contributor
|
The change sounds like a good idea - I've assigned Dan to review the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scaletempo is also not useful with the small changes in playback rate from the slowing down in Syncplay. They're small enough to be more noticeable with it than without, like with interpolation+display-sync.
Besides, mpv has --audio-pitch-correction enabled by default which automatically adds scaletempo when needed.