-
Notifications
You must be signed in to change notification settings - Fork 1
cleanup some url defs #884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
BackendSS has a purpose. When you come to the hackathon tomorrow, I can explain why this is there. |
|
ok, I have returned it in the contexts where it is appropriate, Im just double checking it now |
|
Don't change the name of the variables. These are environment variables already in use with deployments. |
zane-perry
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The GitHub Checks will also have to be updated for this to fully work. Currently the checks get stuck waiting for the Test Suite to pass when only one of the tests (frontend/backend) has run
|
good note, is there any way to make that a file edit, or do we have to use the settings of the repo? |
This pull request makes the tests only run when files in the respective folder are changed. It also removes an unused file, and makes the names for the backend url stuff more consistent across the project.