Skip to content

Allow first-level menu items without children to have blank target #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
loic425 merged 1 commit into from
Apr 28, 2025
Merged

Allow first-level menu items without children to have blank target #254

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/BootstrapAdminUi/templates/shared/crud/common/sidebar/menu/menu.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@
{%- set classes = classes|merge([options.lastClass]) %}
{%- endif %}

{%- set target = item.linkAttributes and item.linkAttributes['target'] ? item.linkAttributes['target'] : '_self' %}

{% set is_active = matcher.isCurrent(item) or matcher.isAncestor(item, options.matchingDepth) or item.getExtra('always_open') %}

{# Mark item as "leaf" (no children) or as "branch" (has children that are displayed) #}
Expand Down Expand Up @@ -60,12 +62,12 @@
</li>
{% else %}
<li class="nav-item">
<a class="nav-link" href="{{ item.uri }}">
<a class="nav-link" href="{{ item.uri }}" target="{{ target }}">
<span class="nav-link-icon d-md-none d-lg-inline-block">
{{ block('icon') }}
</span>
<span class="nav-link-title">
{{ item.label|trans }}
{{ item.label|trans }} {% if target == '_blank' %}{{ ux_icon('tabler:external-link', {'class': 'icon icon-sm ms-1 mb-2 opacity-75'}) }}{% endif %}
</span>
</a>
</li>
Expand Down