Merged
Conversation
diimpp
approved these changes
Dec 9, 2024
Comment on lines
+47
to
+49
| if (!isset($this->clipboard[$this->latestKey])) { | ||
| throw new InvalidArgumentException('There is no latest resource!'); | ||
| } |
Member
There was a problem hiding this comment.
I'm out of context how this function is used, but normally I would expect it to return null, if something is not present.
Member
Author
There was a problem hiding this comment.
yes, indeed
This service is extracted from here
https://github.com/Sylius/Sylius/blob/2.0/src/Sylius/Behat/Service/SharedStorage.php#L52
Member
Author
There was a problem hiding this comment.
I think it's to help debugging Behat scenario issues very quickly.
|
|
||
| public function set(string $key, mixed $resource): void; | ||
|
|
||
| public function getLatestResource(): mixed; |
Member
There was a problem hiding this comment.
I think it's worth documenting @throws for this method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've created a new base branch to create this new package.