Revert completions with build.rs, generate in CI instead#122
Revert completions with build.rs, generate in CI instead#122SuperCuber merged 9 commits intomasterfrom
Conversation
This reverts commit fd4ef23.
|
@TD-Sky wdyt? |
|
We discussed the following about shell completions:
May be Generating shell completions in CI better than doing it in the package building step of various Linux distributions? I'm not so sure. It seems that now it is one of the few answers. |
As we've seen, the reverted PR failed finally cause To be honest, I was haunted by this failure until I found the cargo include field which can specify the published files in crate. I do it in my own crate dagtoc and it runs pretty much perfectly. You need tow steps:
Then the completions generation won't impact publishing to crates.io . (@SuperCuber I sent an email to you but it seems that it entered into your recycle bin, so here I am.) |
|
If we're ignoring completions anyways then it's still done in CI, so might as well keep what works 🤷 Cool that this is possible though :) |
Reverts #118