Hotfix: error types are reserved words #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #42 The error types herein are actually singular versions of our setting keys. Especially clear in the wrong variable name `error_type_` as we actually do *not* iterate over error types but captured word groups.
|
Hey, this only fixed the semantic issue, not the functionality of all the annotations getting the style of the |
Member
Author
|
I released a hotfix for the hotfix shortly after. Sunday. We're on 1.5.3 now. Is that still an issue? |
|
Package control doesnt seem to recognize for me that there is an update, i will tell you as soon as i update the package on my machine. |
|
Package control finally synced, I updated the package and it seems to be fixed. I will check on the other machine tomorrow and will comment here again once I have done so. |
|
I have checked on the other machine, the issue has been fixed, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42
The error types herein are actually singular versions of our setting
keys.
Especially clear in the wrong variable name
error_type_as we actuallydo not iterate over error types but captured word groups.