Skip to content

Conversation

@mamercad
Copy link
Contributor

@mamercad mamercad commented Dec 21, 2022

Striving for:

  • Lint / helm-lint (pull_request)
  • Lint / k8s-lint (pull_request)
  • Unit Tests / helm-unittest (pull_request)
  • E2E Tests / k3s (experimental) (v1.25.4+k3s1) (pull_request)
  • ci/circleci: E2E Tests / minikube

For Circle, the best we can do (because of how the integration works, and, naming restrictions) is likely "ci/circleci: e2e-minikube", mentioned here.

Fixes #343.

@pull-request-size pull-request-size bot added the size/L PR that changes 100-499 lines. Requires some effort to review. label Dec 21, 2022
@mamercad mamercad marked this pull request as ready for review December 21, 2022 14:52
Copy link
Member

@cognifloyd cognifloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit. Otherwise LGTM

@mamercad mamercad changed the title Reorganizing and renaming CI: Reorganizing and renaming Dec 21, 2022
@mamercad mamercad requested a review from cognifloyd December 21, 2022 16:44
@mamercad mamercad changed the title CI: Reorganizing and renaming CI: Reorganize and rename GH and Circle workflows Dec 21, 2022
@cognifloyd cognifloyd enabled auto-merge December 21, 2022 17:41
@cognifloyd cognifloyd merged commit 2f0e9db into StackStorm:master Dec 21, 2022
@cognifloyd
Copy link
Member

K. I adjusted the branch protection to use the new job/workflow names.
I did not add the k3s job as required yet. Once we're ready to say it's not experimental, we can require it as well.

@mamercad mamercad deleted the reorganize-ci branch December 21, 2022 18:24
@mamercad
Copy link
Contributor Author

Excellent, sounds good!

@mamercad
Copy link
Contributor Author

Ahhh, I think we need to update the Badges, stand by.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L PR that changes 100-499 lines. Requires some effort to review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reorganize CI

2 participants