Fix jobs.preRegisterContentCommand init container mounts
#322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/S
cognifloyd
force-pushed
the
fix-preRegisterContentCommand-mounts
branch
from
4682930 to
cf7ac7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initContainer for
jobs.preRegisterContentCommanddid not get some of the updates applied to the primary register-content command container. That may be the source of (part of) the issue reported in #320. Whether or not this fixes that issue, the mounts still need to be fixed / synchronized with the primary mounts.Sadly, testing initContainers with helm-unittest is going to be extremely difficult because it requires assertions using the exact index of the container. When helm-unittest adds support for looking up an object in an array using a key, like name, then we can add tests for initContainers. Until then, we just have to do our best to keep the initContainers synchronized as needed.