template st2client conf #262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/M
Member
Author
|
@armab RFR |
This was referenced Nov 9, 2021
arm4b
approved these changes
Nov 10, 2021
Member
arm4b
left a comment
arm4b
left a comment
There was a problem hiding this comment.
Really nice feature now that would work for everyone!
Thanks a lot for finding the way here 👍
Left one minor comment to address, otherwise looks great.
| # st2client is a special purpose actionrunner pod, but you can customize it separately | ||
| st2client: | ||
| # st2client config (~/.st2/config) template. | ||
| # You can access env variables here because this is used in a bash heredoc. |
Member
There was a problem hiding this comment.
Nice!
Let's just include a link to https://docs.stackstorm.com/reference/cli.html#configuration-file in comments for both Helm value definitions.
That'll help users find the use cases and configuration examples easily.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the
/root/.st2/configtemplate (a bash heredoc) to values so that it can be adjusted based on install requirements. This also makes secrets inenvFromSecretsavailable to thegenerate-st2client-configinitContainers so that they can be used within the bash heredoc template. The template value is also passed throughtplto support helm templating for any non-secret config such as injecting the timezone.Relevant st2 docs on the st2client config file: https://docs.stackstorm.com/reference/cli.html#configuration-file
Closes #233
Closes #256
Closes #261
Note: This PR is an alternate implementation of #256 and #261 based on @armab's feedback in #261.
I want to provide the
ST2_API_KEYviaenvFromSecrets, but the/root/.st2/clientconfig with ausernametakes precedence over theST2_API_KEYenv var. Templating the file allows me to either inject the api_key in the config file, or remove the credentials so that theST2_API_KEYvar is used.