Skip to content

Conversation

@hnanchahal
Copy link

@hnanchahal hnanchahal commented Feb 16, 2021

Closes #134

@pull-request-size pull-request-size bot added the size/M PR that changes 30-99 lines. Good size to review. label Feb 16, 2021
@pull-request-size pull-request-size bot added size/L PR that changes 100-499 lines. Requires some effort to review. and removed size/M PR that changes 30-99 lines. Good size to review. labels Feb 16, 2021
Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! It's good addition and timing for the v3.4.0 release 👍

I left some first review comments to address below.
Once we'll have a flag to enable/disable rbac, it would be nice to run additional helm install with the rbac enabled (via CircleCI test config).

@arm4b arm4b added feature enhancement New feature or request labels Feb 19, 2021
@arm4b arm4b changed the title Removing enterprise flags form rbac configs Refactor Helm templates to configure LDAP/RBAC as OSS, remove Enterprise (v3.4) Feb 26, 2021
Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, looks good! 👍

I left a few more minor comments.
Would be nice to include in .circleci/config.yml additional scenario for helm upgrade with the st2.rbac.enabled=true to make sure the chart is deployable OK. Here is an example from the history: https://github.com/StackStorm/stackstorm-ha/blob/c2e767cf1cde955237f49afb3a8417c05bdfbb43/.circleci/config.yml#L108-L110

Can you please also resolve merge conflicts and sync with the latest master code?

@arm4b
Copy link
Member

arm4b commented Mar 22, 2021

@hnanchahal could you please also sync the PR with the upstream (master) changes? That'll resolve git merge conflicts.

@hnanchahal hnanchahal closed this Mar 22, 2021
@arm4b
Copy link
Member

arm4b commented Mar 22, 2021

Can we please keep the ongoing development and discussion in the original PR (this one) instead of the new #186?

@arm4b arm4b reopened this Mar 22, 2021
@arm4b arm4b added the CI/CD label Mar 24, 2021
Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a pretty big addition and a lot of work.
Many thanks for the contribution! 👍

I've also added Helm Upgrade CI checks with RBAC enabled and included new tests to verify if the RBAC was really loaded and works as part of the normal CI pipeline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change CI/CD enhancement New feature or request feature size/L PR that changes 100-499 lines. Requires some effort to review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EWC/Enterprise transition to OpenSource

2 participants