fix(core-api): use blockHistoryService for first and last block retrieval#63
Merged
Cactus-15-49 merged 1 commit intodevelopfrom Apr 17, 2022
Merged
fix(core-api): use blockHistoryService for first and last block retrieval#63Cactus-15-49 merged 1 commit intodevelopfrom
Cactus-15-49 merged 1 commit intodevelopfrom
Conversation
Cactus-15-49
approved these changes
Apr 17, 2022
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a bug in the upstream code for the Public API which means
/api/blocks/lastraises an Internal Server Error and dumps log spam if the last block in the blockchain contains any multipayments. It would also affect/api/blocks/firstif the genesis block contained one or more multipayments.This PR fixes the bug by calling the
showmethod forfirstandlastin theBlocksControllerso it now fetches the relevant block via theblockHistoryServiceinstead of directly from theblockchainobject. Another benefit of taking this approach is that now the blocks returned viafirstandlastusing?transform=falseare the same structure as when fetching blocks by height or id. For example, the responses from/api/blocks/first?transform=falseand/api/blocks/1?transform=falsewere not identical. Now they are.