fix: upstream database and api performance improvements#137
Merged
Cactus-15-49 merged 4 commits intodevelopfrom Apr 24, 2023
Merged
fix: upstream database and api performance improvements#137Cactus-15-49 merged 4 commits intodevelopfrom
Cactus-15-49 merged 4 commits intodevelopfrom
Conversation
Co-authored-by: alessiodf <35549818+alessiodf@users.noreply.github.com>
Cactus-15-49
approved these changes
Apr 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements some upstream database and Public API performance improvements. It is a composite of the following upstream pull requests:
ArkEcosystem/core#4760
ArkEcosystem/core#4761
ArkEcosystem/core#4764
ArkEcosystem/core#4772
ArkEcosystem/core#4773
We have diverged from the upstream implementation of the second database connection for the Public API in order to prevent a breaking change affecting existing Core plugins that use database repositories. The upstream approach introduces the requirement for a
defaulttag when injecting database repositories outside of the Public API, but ours does not require any tag when used outside of the Public API so existing Core plugins that use database repositories should continue to work normally without needing any changes.