Controller plugin argument 2 is not required.#5
Merged
juriansluiman merged 1 commit intoSoflomo:masterfrom May 28, 2014
Merged
Conversation
Controller plug proxies to service but argument requirements are more restrictive and I don't see why we need to pass an empty array in as the second argument to make it work?
|
You are right, I changed this in the service in e14c18d but I forgot to update the controller plugin. When I'm back home I'll merge your change. Thank you for the pr! |
juriansluiman
pushed a commit
that referenced
this pull request
May 28, 2014
Controller plugin argument 2 is not required.
|
I merged this and released 0.2.2 right away so you could leave out the second parameter. |
Contributor
Author
|
Got it, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Controller plug proxies to service but argument requirements are more restrictive and I don't see why we need to pass an empty array in as the second argument to make it work?