fix: use change_keymap to edit virtual_keyboard's keymap #1903
+74
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bot-wxt1221
force-pushed
the
virtual_keyboard
branch
2 times, most recently
from
3d6c503 to
a9a6e0a
Compare
Contributor
Author
Bot-wxt1221
force-pushed
the
virtual_keyboard
branch
from
a9a6e0a to
a659a34
Compare
Bot-wxt1221
changed the title
Bot-wxt1221
force-pushed
the
virtual_keyboard
branch
5 times, most recently
from
67f4c7e to
b114ff2
Compare
Bot-wxt1221
force-pushed
the
virtual_keyboard
branch
from
b114ff2 to
3bd3c18
Compare
Bot-wxt1221
changed the title
Contributor
Author
Bot-wxt1221
force-pushed
the
virtual_keyboard
branch
from
05bd7d2 to
fd505bc
Compare
Contributor
|
Seems this PR is necessary to unbreak wtype that broke after the last virtual keyboard PR. @Bot-wxt1221 with this PR, wtype works for clients, but for compositor binds it still uses the wrong keymap. I'm actually not sure what's happening. In winit backend, inside the If I do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WM need keymap to process input. So change_keymap is neccessary.
Follow by #1803.
Problem mainly on YaLTeR/niri#2314
Current impl is stupid. The correct way should be simulate a virtual keyboard handler like libinput backend.
But I have no interest in it. So let's just make it possible to solve all issue.