Use FileOptions.Asynchronous when doing async IO#2488
Use FileOptions.Asynchronous when doing async IO#2488JimBobSquarePants merged 3 commits intoSixLabors:mainfrom
FileOptions.Asynchronous when doing async IO#2488Conversation
|
|
JimBobSquarePants
left a comment
JimBobSquarePants
left a comment
There was a problem hiding this comment.
Looks great, just some naming changes to implement to match project convention. Thanks for helping out!
| /// <param name="path">Path to the file to open.</param> | ||
| /// <returns>A stream representing the file to open.</returns> | ||
| /// <returns>A stream representing the opened file.</returns> | ||
| Stream OpenReadAsynchronous(string path); |
There was a problem hiding this comment.
I would use Async as the suffix to match convention.
There was a problem hiding this comment.
@JimBobSquarePants I agree that the Asynchronous suffix looks weird, but I didn't use the Async suffix because the method isn't actually async and doesn't return a Task or anything awaitable. Having that suffix would be misleading and would actually go against the convention. Do you really want to go against the guidelines and have an Async suffix even though the method is synchronous and can't be awaited?
There was a problem hiding this comment.
Ah yeah, I misread the code before. Naming is fine then. I'm not that precious about it since it's internal.
3 participants
Prerequisites
Description
Fixes #2487