Update all dependency references.#1262
Conversation
|
No idea what or why this is happening. Can get the tests to run locally without crashing either because ImageMagick decoder always crashes https://github.com/SixLabors/ImageSharp/runs/845593121?check_suite_focus=true#step:7:97 |
|
@antonfirsov I think we need to reevaluate our usage of https://github.com/SixLabors/ImageSharp/runs/859311527?check_suite_focus=true#step:7:195 It does look like there's a way with Xunit to run code once at startup which would mean we could move it out of static contructors. |
|
@JimBobSquarePants the last test failure I see is because of Magic.NET. What if we revert updating that, and address it in a separate PR? I like the |
|
Since it's a test-only change, I don't see a point to keep the 1.0 milestone. |
|
I was going to update the .NET references also. I'll have one last crack in a mo but if that fails I'll scrap it. |
Codecov Report
@@ Coverage Diff @@
## master #1262 +/- ##
=======================================
Coverage 82.68% 82.68%
=======================================
Files 697 697
Lines 30589 30589
Branches 3460 3460
=======================================
Hits 25294 25294
Misses 4593 4593
Partials 702 702
Continue to review full report at Codecov.
|
|
@antonfirsov Turns out |
|
I'm just gonna go ahead and merge this now since there are no code changes. |
Prerequisites
Description
Just a simple update to all reference dependencies. Might help with any .NET FX type forwarding issues