Simplify and cleanup build constants#1075
Merged
JimBobSquarePants merged 3 commits intomasterfrom Jan 10, 2020
Merged
Conversation
JimBobSquarePants
requested review from
antonfirsov,
brianpopow,
dlemstra and
tocsoft
dlemstra
reviewed
Jan 9, 2020
Codecov Report
@@ Coverage Diff @@
## master #1075 +/- ##
==========================================
+ Coverage 89.95% 89.95% +<.01%
==========================================
Files 1200 1200
Lines 53013 53010 -3
Branches 3847 3847
==========================================
- Hits 47689 47687 -2
+ Misses 4556 4555 -1
Partials 768 768
Continue to review full report at Codecov.
|
Member
Author
|
Imma gonna go ahead with this now I've consolidated the build constants. I want to move on to #1076 |
antonfirsov
approved these changes
Jan 10, 2020
Member
antonfirsov
left a comment
antonfirsov
left a comment
There was a problem hiding this comment.
lgtm after a quick review on mobile
This was referenced Jul 30, 2025
This was referenced Oct 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
As part of the move to externalize ImageSharp.Drawing and import Core I thought it wise to simplify and normalize our use of #ifdefs throughout the library.
Once we have a CI build environment that works on .NET Core 3.1 we can easily add additional target frameworks.
Touch #1002