[v2 sync] Update 3rd party deps #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
art-alexeyenko
commented
Jan 29, 2025
| "nyc": "^17.1.0", | ||
| "sinon": "^19.0.2", | ||
| "tslib": "^2.8.1", | ||
| "tsx": "^4.19.2", |
Contributor
Author
There was a problem hiding this comment.
I replace ts-node with tsx here as pre-prep for ESM switch. ts-node only works with CJS.
However, tsx causes problems with sinon.stub in other packages - which we'll need to figure out later.
addy-pathania
suggested changes
Jan 29, 2025
Contributor
addy-pathania
left a comment
addy-pathania
left a comment
There was a problem hiding this comment.
Great work on this!
Some dependencies were updated to the latest or were missed. Please clarify the reason.
This reverts commit d166a46.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Motivation
Some dependencies are not updated, as they need ESM support:
- inquirer
- sass-alias
Testing Details
Types of changes