Skip to content

[sitecore-jss-nextjs] Replace Enzyme by @testing-library #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
addy-pathania merged 2 commits into from
Jan 28, 2025
Merged

[sitecore-jss-nextjs] Replace Enzyme by @testing-library #16

addy-pathania merged 2 commits into from
Jan 28, 2025

Conversation

@illiakovalenko
Copy link
Collaborator

@illiakovalenko illiakovalenko commented Jan 28, 2025 •
edited
Loading

Description / Motivation

  • Migrated unit tests to use "testing-library"
  • Removed obsolete yarn resolutions

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

addy-pathania
addy-pathania approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@addy-pathania addy-pathania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@addy-pathania addy-pathania merged commit 4293c1d into dev Jan 28, 2025
1 check passed
@addy-pathania addy-pathania deleted the feature/JSS-4939 branch January 28, 2025 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@addy-pathania addy-pathania addy-pathania approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@illiakovalenko @addy-pathania