Update azure-pipelines.yml to publish canary #14
Conversation
illiakovalenko
left a comment
illiakovalenko
left a comment
There was a problem hiding this comment.
- Token generation logic should be updated to check for "beta" as well, see here. Here I want to ask you to improve token resolution and just use a regexp without additional check, like this one
[a-z](\.\d+). Instead of checking additionally for "canary" or "beta, we can just remove any possible build number. - Let's remove this reference in BYOC to sitecore-jss and XP, here
- Update README
- Noticed a random thing, let's remove this rn-config
|
@addy-pathania Regarding canary token "build number removal" you can see here how it's done, since I proposed the same to Stas |
| displayName: 'lint samples' | ||
| condition: and(succeeded(), ne(variables.shouldPublish, true)) | ||
|
|
||
| # skipping the following steps until we publish the first canary |
There was a problem hiding this comment.
skipping scaffolding samples since it tries to install dependencies from remote npm registery.
Will revert this after we publish first canary.
art-alexeyenko
left a comment
art-alexeyenko
left a comment
There was a problem hiding this comment.
@addy-pathania This is huge, well done.
I've found a couple things that should be addressed before we merge, and I'll check the rest once these are done:
- Ensure every package (plus sample) has the correct version in package.json
- Manually re-generate ref-docs. You'll need to remove the old folders and create new ones per package
|
@addy-pathania there's one leftover reference to with it, nextjs app doesn't build. Please also update CONTRIBUTING.MD and README.md to outline the new flow for creating apps (with new names) and cleanup the old package names. |
art-alexeyenko
left a comment
art-alexeyenko
left a comment
There was a problem hiding this comment.
Looks good!
Let's publish this fella
Description / Motivation
@sitecore-content-sdksitecore-jssprefixTesting Details
Types of changes