fix callback_url param error when query params are also included #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ecwid seems to have made a change at some point in the recent past whereby they now require the 'redirect_uri' parameter to EXACTLY match what is in their app settings - ie, even having query_string parameters is causing a redirect_uri match failed permission issue when generating the access token.
By default, omniauth takes whatever code url arrives and uses that as the 'redirect_uri' parameter when generating the access_token request. With this PR, we now remove any query_string parameters from the redirect_uri before it goes on to the access_token request.
This fixed our problems, maybe it will help someone else...