[java] restore ClientConfig constructor used by Appium (for backward compatibility)#16874
Conversation
… backward compatibility) This constructor disappeared in PR SeleniumHQ#16796 when `wsTimeout` parameter was added.
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
||||||||||||||||||||||||
PR Code Suggestions ✨Explore these optional code suggestions:
|
|||||||||
User description
This constructor disappeared in PR #16796 when
wsTimeoutparameter was added.But Appium still uses it.
People would not be able to update Selenium version, while staying on a previous Appium version.
💥 What does this PR do?
Restores
ClientConfigconstructor (withoutwsTimeoutparameter) that existed in Selenium 4.39.0.🔄 Types of changes
PR Type
Bug fix
Description
Restores removed
ClientConfigconstructor for backward compatibilityConstructor without
wsTimeoutparameter used by AppiumDelegates to full constructor with default
wsTimeoutvalueExtracts timeout defaults into private helper methods
Diagram Walkthrough
File Walkthrough
ClientConfig.java
Restore constructor and extract timeout defaultsjava/src/org/openqa/selenium/remote/http/ClientConfig.java
wsTimeoutparameter thatdelegates to existing constructor
methods (
defaultWsTimeout(),defaultReadTimeout(),defaultConnectionTimeout())defaultConfig()method to use the new helper methods forcleaner code
the old constructor signature