[py] Remove unused mocker arg in chrome options test#15540
Merged
cgoldberg merged 1 commit intoSeleniumHQ:trunkfrom Mar 31, 2025
Merged
[py] Remove unused mocker arg in chrome options test#15540cgoldberg merged 1 commit intoSeleniumHQ:trunkfrom
cgoldberg merged 1 commit intoSeleniumHQ:trunkfrom
Conversation
Contributor
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
Contributor
PR Code Suggestions ✨No code suggestions found for the PR. |
This was referenced Dec 21, 2025
This was referenced Jan 19, 2026
This was referenced Feb 16, 2026
This was referenced Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Motivation and Context
This PR removes an unused argument in a Python unit test:
py/test/unit/selenium/webdriver/chrome/chrome_options_tests.pymockerwas getting passed to this test, but not used in the test.Unit tests still pass fine and this should have no effect.
Types of changes
Checklist
PR Type
Bug fix
Description
Removed unused
mockerargument from a unit test.Simplified the test function signature for clarity.
Ensured no impact on existing unit test functionality.
Changes walkthrough 📝
chrome_options_tests.py
Removed unused `mocker` argument in test functionpy/test/unit/selenium/webdriver/chrome/chrome_options_tests.py
mockerargument from thetest_get_extensions_from_encoded_extensionsfunction.parameters.