[dotnet] Annotate nullable reference types on CDP-generated code#15255
Merged
RenderMichael merged 5 commits intoSeleniumHQ:trunkfrom Feb 28, 2025
Merged
[dotnet] Annotate nullable reference types on CDP-generated code#15255RenderMichael merged 5 commits intoSeleniumHQ:trunkfrom
RenderMichael merged 5 commits intoSeleniumHQ:trunkfrom
Conversation
Contributor
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
Contributor
PR Code Suggestions ✨No code suggestions found for the PR. |
24 tasks
sandeepsuryaprasad
pushed a commit
to sandeepsuryaprasad/selenium
that referenced
this pull request
Mar 23, 2025
This was referenced Dec 21, 2025
This was referenced Jan 19, 2026
This was referenced Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Annotates nullable reference types on CDP-generated code
Motivation and Context
Contributes to #14640
Types of changes
Checklist
PR Type
Enhancement, Bug fix
Description
Annotated nullable reference types across CDP-generated code.
Updated type mappings to handle optional types consistently.
Enabled nullable context in multiple template files.
Improved event handling with nullable support in generated code.
Changes walkthrough 📝
8 files
Annotated nullable reference types for event invoker.Added nullable property for return types in command definitions.Enabled nullable context and added default values for requiredproperties.Enabled nullable context and improved event handling.Enabled nullable context and added default values for requiredproperties.Enabled nullable context in type-enum template.Enabled nullable context and added default values for requiredproperties.Enabled nullable context and added default values for requiredproperties.1 files
Adjusted type mappings for optional and array types.