[dotnet] Unify protected and internal Execute methods#15233
[dotnet] Unify protected and internal Execute methods#15233RenderMichael merged 4 commits intoSeleniumHQ:trunkfrom
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
nvborisenko
left a comment
There was a problem hiding this comment.
Approved. I think this PR is still actual, so just actualize it and move forward. Thank you!
|
Test failures are unrelated: //dotnet/test/common:BiDi/Network/NetworkEventsTest-firefox
//java/test/org/openqa/selenium/mobile:NetworkConnectionTest
//java/test/org/openqa/selenium/remote:RemoteWebDriverScreenshotTest
//java/test/org/openqa/selenium/remote:RemoteWebDriverScreenshotTest-firefox-beta
//rb/spec/integration/selenium/webdriver:network-firefox-beta-bidi
//rb/spec/integration/selenium/webdriver:network-firefox-bidi |
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
protected+internal->protected internalMotivation and Context
Less overloads, shorter stack traces, less maintenance.
Types of changes
Checklist
PR Type
Enhancement, Bug fix
Description
Unified
InternalExecuteandExecutemethods into a singleprotected internalmethod.Replaced all occurrences of
InternalExecutewithExecuteacross multiple classes.Added null checks for constructor parameters in
HttpCommandInfo.Simplified and streamlined method calls for better maintainability and reduced stack traces.
Changes walkthrough 📝
10 files
Replaced `InternalExecute` with `Execute` in alert handling.Replaced `InternalExecute` with `Execute` in cookie management.Replaced `InternalExecute` with `Execute` in log retrieval.ReplacedInternalExecuteAsyncwithExecuteAsyncin navigation methods.ReplacedInternalExecutewithExecutein shadow DOM element handling.ReplacedInternalExecutewithExecutein frame and window switching.Replaced `InternalExecute` with `Execute` in timeout management.Unified
InternalExecuteandExecutemethods into a singleprotectedinternalmethod.ReplacedInternalExecutewithExecutein element-specific commands.Replaced `InternalExecute` with `Execute` in window management.1 files
Added null checks for constructor parameters.