feat: auto-delete in voice-chat feature#72
Conversation
…ing of voice-channels config
SCDerox
left a comment
There was a problem hiding this comment.
Hi, thanks so much for your contribution!
I found have some small things which I have added as comments. The features of the changes seem to work correctly (tested in prod-like environment). Also: Do not feel pressured to implement my comments right away, I am happy to discuss them if you feel like your way of doing something is better (except the missing import, that should be fixed).
Thanks again for your contribution!
If you want to receive a small bountie for this contribution, please follow these instructions before re-requesting a review. Thanks ^^
85a13b9 to
1bb6a32
Compare
|
Would be good if you double check the changes again. I did some refactoring and added error handling for the "channel.message.fetch" |
SCDerox
left a comment
There was a problem hiding this comment.
Thanks so much for your contribution! Unfortunatly, as of right now, the feature you want to add does not work properly. Please fix the mentioned bug in my comments.
|
Oh also btw: We tend to use a different commit-message-format (compare https://github.com/SCNetwork/CustomDCBot/commits/main), it would be great if you could adapt it for future commits. |
|
I have added some more detailed description in both languages. Does it work? Couldn´t find any info about that in the README.md |
SCDerox
left a comment
There was a problem hiding this comment.
Sorry for annoying you once again, could you upgrade your changes to v3.5.0? Should only affect locales as far as I can see. (also everything works now with your changes; i have found two localization issues, please fix them in both files)
|
I will upgrade it to the latest version as soon as i have time. I didnt read your message |
|
Sorry, but I can not fix these merge issues as I am not the owner of the torbenprobst/CustomDCBot repository. Please try fixing the merge conflict yourself, feel free to reach out if you need help. |
2e2756b to
563f64c
Compare
|
Should be fixed now. Pls review again @SCDerox |
SCDerox
left a comment
There was a problem hiding this comment.
lgtm 👍
Thanks so much for your contribution and sorry for all the pity changes I requested. Your code will be merged shortly. SCNX users can expect to receive your update on the beta branch this afternoon. Unfortunately, we can not share an ETA for the main branch, but it's typically 1-2 work days.
You'll receive small bounty in accordance with our Open-Source-Developer-Program credited to you organization. If you have any questions about this or the payout of the amount, please contact ScootKit support.
Thanks again!
This is the feature PR for the module auto-delete.
Features added:
Tests: